Change param file handling for java and in image creator #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ran into an issue recently where the length of classpaths after flipping to bzlmod, with its longer paths, caused failure at runtime because the classpath argument was over the default limits for linux. This just sets the classpath being in a file as the default (and exposes a flag to turn it off). The core functionality was already present. We were previously using '@<path>' to indicate arg files in the create_image_config program. This was changed to @@ because the entrypoint arguments that are passed in might *also* start with a single '@' because they are param files meant for the JVM
denbeigh2000
approved these changes
Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into an issue recently where the length of classpaths after flipping to bzlmod, with its longer paths, caused failure at runtime because the classpath argument was over the default limits for linux. This just sets the classpath being in a file as the default (and exposes a flag to turn it off). The core functionality was already present.
We were previously using '@' to indicate arg files in the create_image_config program. This was changed to @@ because the entrypoint arguments that are passed in might also start with a single '@' because they are param files meant for the JVM